Respect the return qualifier for attributes on class methods #19025
+178
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
DragonSA
force-pushed
the
fix-returnattr
branch
from
96ebdd6 to
30f5af1
Compare
DragonSA
force-pushed
the
fix-returnattr
branch
from
30f5af1 to
41a384b
Compare
edgarfgp
reviewed
Oct 24, 2025
There was a problem hiding this comment.
Please minimise the diff. So it is easier to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attributes attached to the return value of a class method (e.g.
[<return: NotNull>]) were instead being attached to the method itself. This did not happen for functions (let bind). I refactored the logic out ofTcNormalizedBinding(used byTcLetBindingand used that inAnalyzeAndMakeAndPublishRecursiveValue.Fixes #19020
Checklist